Cherry-pick handleValue panic fix to release/v20.03 #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: DGRAPH-1608 srcFn.n should be equal to len(q.UidList.Uids) for implementation DivideAndRule and calculate to work correctly. But we have seen some panics while forming DataKey in calculate(). panic is of the form "index out of range [4] with length 1". We have tried to reproduce this but couldn't find any edge case which will result in this panic. So for now we are just logging when srcFn.n != len(q.UidList.Uids) and returning error when this happens. (cherry picked from commit 2184268)
ashish-goswami
requested review from
danielmai,
manishrjain,
martinmr,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
poonai
approved these changes
Jun 18, 2020
jarifibrahim
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, @martinmr, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick handleValue panic fix to release/v20.03
This change is
Docs Preview: